PostHog Handbook Library / Engineering

908 words. Estimated reading time: 5 min.

Feature ownership

Each feature at PostHog has an Engineering owner. This owner is responsible for maintaining the feature (keep the lights on), championing any efforts to improve it (e.g. by bringing up improvements in sprint planning), planning launches for new parts of it, and making sure it is well documented.

For shared developer tooling and infrastructure that cuts across product teams (CI, local dev, builds, migrations, etc.), see the Developer Experience page.

When a bug or feature request comes in, we tag it with the relevant label (see labels below). The owner is responsible for then prioritizing any bug/request that comes in for each feature. This does not mean working on every bug/request, an owner can make the deliberate decision that working on something is not the best thing to work on, but every request should be looked at.

Who can contribute to owned features?

Feature ownership does not mean that the owner is the only person/team who can contribute to the feature. If another team requires something from an existing feature that isn't supported, that non-owning team builds it. How you start depends on the size of the change (see PR or context?). The owner team is responsible for reviewing PRs to make sure the code patterns and UX makes sense for the feature overall. After the change is merged, the owner team then owns it (assuming no major bugs from the initial implementation).

For example, web analytics wanted a heatmap insight type to see what times of day people were active. Javier Bahamondes from web analytics opened up the necessary PRs to build this feature. It was reviewed by the , owner of all insight types, who then took responsibility for it after it was merged.

This process does four things:

PR or context?

"Context" means a Slack message or issue to the owning team that explains the problem and why it matters, without code.

| Change | Suggested path | | ----------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------- | | Typo or small bug | Open a PR, then tell the owning team. | | Small improvement (one screen, no new behavior) | Open a PR, then tell the owning team. If you don't know that code well, check with them first. | | New feature, or a change in how something works | Give the owning team context first. Once they agree on the approach, you build it. A draft PR can come with the context, and they are free to close it. |

The bigger the change, the more it shapes the owning team's direction, and they maintain it after it merges, so they get a say before the code exists.

Not sure which row fits your change? If all else fails, ask the owning team. Not sure who owns it? See Fuzzy ownership.

If you open the PR, you own it

The owning team maintains your code after it merges, so they review it as their own. Generating a PR takes minutes, so the PR itself isn't the work. Before you ask the owning team for a review, understand the change well enough to explain it and its tradeoffs without the diff open. "I pointed an agent at this" is not a description. Then follow Before requesting a review.

What the owning team does

Expect that the owning team may close your PR and build the change their own way. That's a normal outcome, not a judgment of your work.

If you don't usually write code

The same tiers and the same ownership bar apply to you. If you aren't sure how the code you're changing works, ask the owning team before you open the PR, not after.

Feature list

You can also view the list directly in GitHub and filter issues there.

Don't just copy other products

Some of the features we are building may exist in other products already. It is fine for us to be inspired by them - there's no need to reinvent the wheel when there is already a standard way our users expect things to work. However, it is not ok for us to say 'let's copy how X does it', or to ship something with the exact same look and feel as another product. This is bad for two reasons:

Canonical URL: https://posthog.com/handbook/engineering/feature-ownership

GitHub source: contents/handbook/engineering/feature-ownership.md

Content hash: d4b7d66765e776b7

Static reader notes
  • MDX_COMPONENT_STATIC_ADAPTER: Adapted interactive MDX components for static reading: FeatureOwnershipTable, SmallTeam, TeamMember.